Francesco Romani has posted comments on this change. Change subject: logs: improve VDSM logs human-readability ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/28869/4/vdsm/logger.conf.in File vdsm/logger.conf.in: Line 66: [formatter_none] Line 67: format: %(message)s Line 68: Line 69: [formatter_long] Line 70: format: %(asctime)s %(levelname)s %(threadName)s [%(name)s ::%(module)s in function %(funcName)s %(pathname)s:%(lineno)d]: %(message)s > Only redundant if you know the location of each module by heart. Sure, you Because this reduces the signal/noise ratio :) It is a compromise, as usual. This information can be easily inferred, and having on each line costs visual space and log size. I don't care about the sheer size (the smallest HDD I can buy nowadays is half a terabyte...) but larger logs mean less content when they are rotated, or bulkier chunks to load in my editor, etc. Line 71: Line 72: [formatter_sysform] Line 73: format= vdsm %(name)s %(levelname)s %(message)s Line 74: datefmt= -- To view, visit http://gerrit.ovirt.org/28869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65fcc843b4c2c6f1b0f438937a0702b80b714978 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Marina Kalinin <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
