Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Fix unsafe iteration of domain monitor status ......................................................................
Patch Set 1: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/29009/1/vdsm/storage/domainMonitor.py File vdsm/storage/domainMonitor.py: Line 119 Line 120 Line 121 Line 122 Line 123 as long as we're changing a public function, how about less name inflation? getStatus instead of getMonitoredDomainsStatus Line 118: Line 119: del self._domains[sdUUID] Line 120: Line 121: def getMonitoredDomainsStatus(self): Line 122: for sdUUID, monitor in self._domains.items(): how is this safer? if _domains changes, the list you get from items is invalid, and you will yield invalid values. What am I missing? Line 123: yield sdUUID, monitor.getStatus() Line 124: Line 125: def close(self): Line 126: self.log.info("Stopping domain monitors") -- To view, visit http://gerrit.ovirt.org/29009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I083c4b1925ee529c0993a291cad6076539d4ea66 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Xavi Francisco <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
