Dan Kenigsberg has submitted this change and it was merged. Change subject: domainMonitor: Fix unsafe iteration of domain monitor status ......................................................................
domainMonitor: Fix unsafe iteration of domain monitor status When we generate repoStat response, we used to iterate over the monitored domains, getting the status for each monitor. This naïve approach does not consider that a monitor may be removed from the domain monitor dict during the iteration. Since the only usage now is getting the status for all domains, I changed getStatus to return an iterator returning all domains status in a safe manner. Change-Id: I083c4b1925ee529c0993a291cad6076539d4ea66 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/29009 Reviewed-by: Yoav Kleinberger <[email protected]> Reviewed-by: Federico Simoncelli <[email protected]> --- M vdsm/storage/domainMonitor.py M vdsm/storage/hsm.py 2 files changed, 4 insertions(+), 5 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved Yoav Kleinberger: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I083c4b1925ee529c0993a291cad6076539d4ea66 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Xavi Francisco <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
