Nir Soffer has posted comments on this change. Change subject: domainMonitor: Fix unsafe status handling ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/29014/1//COMMIT_MSG Commit Message: Line 11: was written as if creating a new status object is expensive operation Line 12: that should be avoided. Line 13: Line 14: Instead of having long living status object in the monitor, I create new Line 15: forozen copy each monitor internal (10 seconds). The frozen copy ensure > "interval", not "internal" will fix Line 16: that careless developers trying to modify a status will get what they Line 17: deserve. Line 18: Line 19: Change-Id: If4affb67b6e65382dc4e55ebad9443e2722f2773 http://gerrit.ovirt.org/#/c/29014/1/vdsm/storage/domainMonitor.py File vdsm/storage/domainMonitor.py: Line 59: self.isoPrefix = None Line 60: self.version = -1 Line 61: Line 62: Line 63: class FrozenStatus(DomainMonitorStatus): > This class should be private to this module, _FrozenStatus It uses the same visibility as is superclass - why do you care about its privacy? If we go in this direction, we should make everything here private except the DomainMonitor class. I don't mind making these private, although I'm not happy work with all those _PrivateClass, but it is not related to this patch. Line 64: Line 65: def __init__(self, other): Line 66: for name in other.__slots__: Line 67: value = getattr(other, name) -- To view, visit http://gerrit.ovirt.org/29014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4affb67b6e65382dc4e55ebad9443e2722f2773 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Xavi Francisco <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
