Nir Soffer has posted comments on this change. Change subject: domainMonitor: Fix unsafe status handling ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29014/1/vdsm/storage/domainMonitor.py File vdsm/storage/domainMonitor.py: Line 59: self.isoPrefix = None Line 60: self.version = -1 Line 61: Line 62: Line 63: class FrozenStatus(DomainMonitorStatus): > I don't agree that simply because you return some object, its class should But if we treat DomainMonitorStatus as private, people may assume that it is not accessed outside this module, and remove an instance variable used from another module. This is how it work in languages enforcing privacy like java. Since we don't have interfaces, what left is have public like names for such classes. Line 64: Line 65: def __init__(self, other): Line 66: for name in other.__slots__: Line 67: value = getattr(other, name) -- To view, visit http://gerrit.ovirt.org/29014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4affb67b6e65382dc4e55ebad9443e2722f2773 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Xavi Francisco <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
