Nir Soffer has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/28873/5/vdsm/storage/clusterlock.py File vdsm/storage/clusterlock.py: Line 56: class HostStatusNotAvailable(Exception): Line 57: """ Line 58: Raised when host status is not available because the cluster lock does not Line 59: support this operation, or raised an exception. Line 60: """ > if this future arrives, we can deal with it then. YAGNI The future is here - this module already has 3 types of clusterlocks, raising sanlock specific error is not acceptable now. Line 61: Line 62: Line 63: class SafeLease(object): Line 64: log = logging.getLogger("Storage.SafeLease") -- To view, visit http://gerrit.ovirt.org/28873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccd62e58a194aa0ceb0f5e2503b8ec7e4349971b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Xavi Francisco <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
