Michal Skrivanek has posted comments on this change.

Change subject: vm: hyperv: make hw clock friendlier to windows
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/29233/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 722:         m = XMLElement('clock', offset='variable',
Line 723:                        adjustment=str(self.conf.get('timeOffset', 0)))
Line 724:         rtc = m.appendChildWithArgs('timer', name='rtc', 
tickpolicy='catchup')
Line 725:         if utils.tobool(self.conf.get('hypervEnable', 'false')):
Line 726:             rtc.setAttrs(track='guest')
track = guest? should be name= hypervclock
Line 727:         m.appendChildWithArgs('timer', name='pit', tickpolicy='delay')
Line 728: 
Line 729:         if self.arch == caps.Architecture.X86_64:
Line 730:             m.appendChildWithArgs('timer', name='hpet', present='no')


-- 
To view, visit http://gerrit.ovirt.org/29233
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84a8cfded683a42826b6dabb67b4a5eb456594d7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to