Francesco Romani has posted comments on this change. Change subject: vm: hyperv: make hw clock friendlier to windows ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29233/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 722: m = XMLElement('clock', offset='variable', Line 723: adjustment=str(self.conf.get('timeOffset', 0))) Line 724: rtc = m.appendChildWithArgs('timer', name='rtc', tickpolicy='catchup') Line 725: if utils.tobool(self.conf.get('hypervEnable', 'false')): Line 726: rtc.setAttrs(track='guest') > track = guest? should be name= hypervclock The libvirt docs/support is quite murky here. hypervclock is supported u/s starting from 1.2.2, and AFAIK RHEL 6.x is left out, as well as F19 and F20 without virt-preview. (and I'm not that sure anput RHEL7, need to check). Support in VDSM is added in http://gerrit.ovirt.org/#/c/29234/ Then bz1107835 comes into play. We have a reported way to improve stability which is safe to add, plays nice on RHEL 6 and fits nicely on our hyperv support, so I added in this patch. The open question is if name=hypervclock behaves the same way of name=rtc track=guest. :( Line 727: m.appendChildWithArgs('timer', name='pit', tickpolicy='delay') Line 728: Line 729: if self.arch == caps.Architecture.X86_64: Line 730: m.appendChildWithArgs('timer', name='hpet', present='no') -- To view, visit http://gerrit.ovirt.org/29233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84a8cfded683a42826b6dabb67b4a5eb456594d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
