Dan Kenigsberg has posted comments on this change. Change subject: net: skip network restoration if its physical devs are missing ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/29313/1/vdsm/vdsm-restore-net-config File vdsm/vdsm-restore-net-config: Line 67: Line 68: # Filter out nets and bonds that use devices which are not present Line 69: available_nics = netinfo.nics() Line 70: unavailable_bonds = {} Line 71: for bond, attrs in bonds.items(): how about taking a more optimistic approach on recovery? as long as a bond has a single standing nic, we can go on enabling it. Line 72: unavailable_bond_nics = any(nic for nic in attrs['nics'] if Line 73: nic in available_nics) Line 74: if unavailable_bond_nics: Line 75: unavailable_bonds[bond] = bonds.pop(bond) -- To view, visit http://gerrit.ovirt.org/29313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f1370696f2398fe2c3cd9ad92424b126bcd4b7c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
