Dan Kenigsberg has posted comments on this change. Change subject: net: skip network restoration if its physical devs are missing ......................................................................
Patch Set 2: Code-Review+1 (2 comments) I'd give me +2, as I want this bug fixed asap, but I know you care about python 3 http://gerrit.ovirt.org/#/c/29313/2/vdsm/vdsm-restore-net-config File vdsm/vdsm-restore-net-config: Line 74: Line 75: if available_bond_nics: Line 76: attrs['nics'] = available_bond_nics Line 77: else: Line 78: unavailable_bonds[bond] = bonds.pop(bond) This pop() would bite us on Python3, where bonds.items() is an iterator. Line 79: Line 80: for net, attrs in nets.items(): Line 81: bond = attrs.get('bonding') Line 82: if bond is not None: Line 84: logging.error('Some of the nics required by bond "%s" (%s) ' Line 85: 'are missing. Network "%s" will not be ' Line 86: 'configured as a consequence', bond, Line 87: unavailable_bonds[bond]['nics'], net) Line 88: del nets[net] and these del[]s, too. Line 89: else: Line 90: continue Line 91: Line 92: nic = attrs.get('nic') -- To view, visit http://gerrit.ovirt.org/29313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f1370696f2398fe2c3cd9ad92424b126bcd4b7c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
