Nir Soffer has posted comments on this change. Change subject: signals: Better handle signals to non-main threads ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/29392/1//COMMIT_MSG Commit Message: Line 8: Line 9: There is an issue with using signal.pause() and threads in python. The signal Line 10: might arrive to a non-main thread, and not get processed (because only the Line 11: main thread handles signals) until the main thread receives its own signal. Line 12: The issue is documented and tracked here: This is related only to functions that block the main thread until it is interrupted, like time.sleep and signal.pause. If the main thread is running python code is will run the signal handler even without receiving another signal. Line 13: https://bugzilla.redhat.com/show_bug.cgi?id=1114434 Line 14: Line 15: Change-Id: I5dbcd00cec22ef12f2b6253b016dcbd0aa889583 Line 9: There is an issue with using signal.pause() and threads in python. The signal Line 10: might arrive to a non-main thread, and not get processed (because only the Line 11: main thread handles signals) until the main thread receives its own signal. Line 12: The issue is documented and tracked here: Line 13: https://bugzilla.redhat.com/show_bug.cgi?id=1114434 Also this is not really a python bug, this is how pause works - it does not wake up when another thread receive SIGCHLD. Line 14: Line 15: Change-Id: I5dbcd00cec22ef12f2b6253b016dcbd0aa889583 -- To view, visit http://gerrit.ovirt.org/29392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dbcd00cec22ef12f2b6253b016dcbd0aa889583 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
