Dima Kuznetsov has posted comments on this change. Change subject: signals: Handle signals to non-main threads ......................................................................
Patch Set 3: (4 comments) http://gerrit.ovirt.org/#/c/29392/3/lib/vdsm/sigutils.py File lib/vdsm/sigutils.py: Line 55: Line 56: poller = select.poll() Line 57: poller.register(read_fd, select.POLLIN) Line 58: Line 59: _signalPoller = poller > rename oops Line 60: Line 61: return _signalPoller Line 62: Line 63: Line 57: poller.register(read_fd, select.POLLIN) Line 58: Line 59: _signalPoller = poller Line 60: Line 61: return _signalPoller > rename oops Line 62: Line 63: Line 64: def wait_for_signal(): Line 65: ''' Line 74: try: Line 75: events = poller.poll() Line 76: for fd, event in events: Line 77: if event & select.POLLIN: Line 78: os.read(fd, 128) > I missed this last time: now when this is non-blocking as well, this read c you're right Line 79: except select.error as e: Line 80: # Log all error except EINTR Line 81: if (e[0] != errno.EINTR): Line 76: for fd, event in events: Line 77: if event & select.POLLIN: Line 78: os.read(fd, 128) Line 79: except select.error as e: Line 80: # Log all error except EINTR > This comment is pointless. you're right Line 81: if (e[0] != errno.EINTR): -- To view, visit http://gerrit.ovirt.org/29392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dbcd00cec22ef12f2b6253b016dcbd0aa889583 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
