Liron Aravot has posted comments on this change. Change subject: core: GET requests - use Range header ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/28465/8/vdsm/BindingXMLRPC.py File vdsm/BindingXMLRPC.py: Line 284: raise self.RequestException( Line 285: httplib.BAD_REQUEST, Line 286: "unspecified range last byte position isn't supported") Line 287: Line 288: return self._getInt(last_byte) + 1 > I like what Nir proposes. It's less code and cleaner. Although I don't want I prefer to keep it as is, it's already verified and i think that as we don't "truly" support range at the moment, this information will be useful. When we'll add more range "cases" the messages here would be useful to understand what's wrong rather than generic error. as it's already verified, let's leave as is. Line 289: Line 290: def send_error(self, error, message, exc_info=False): Line 291: try: Line 292: self.log.error(message, exc_info=exc_info) -- To view, visit http://gerrit.ovirt.org/28465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8164867347b1cf800efd2a78cc98dbc10c02ee0d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
