Nir Soffer has posted comments on this change. Change subject: Add soft dependency on libvirt's metadata support to stats collector ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/29504/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 300: return infos[2] Line 301: Line 302: def _sampleVmJobs(self): Line 303: return self._vm.queryBlockJobs() Line 304: _libvirt_metadata_supported is used only by this method, so why not define the class variable right here near the method? This way this hack is localized and easier to understand and clean up later. Line 305: def _sampleCpuTune(self): Line 306: infos = self._vm._dom.schedulerParameters() Line 307: infos['vcpuCount'] = self._vm._dom.vcpusFlags( Line 308: libvirt.VIR_DOMAIN_VCPU_CURRENT) -- To view, visit http://gerrit.ovirt.org/29504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d38d3aff3bda42dfaafa87bab9fa5983fb4b9a8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
