Nir Soffer has posted comments on this change. Change subject: Add soft dependency on libvirt's metadata support to stats collector ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/29504/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-07-02 11:30:26 -0400 Line 6: Line 7: Add soft dependency on libvirt's metadata support to stats collector Line 8: Line 9: There is an issue with libvirt on CentOS 6. The available version does not support part of the metadata API. This generates an error message every 15 seconds. Can you wrap lines? Line 10: Line 11: This patch workarounds this by printing the error only once. Line 12: Line 13: Revert once libvirt supports the xml element metadata on CentOS. Line 7: Add soft dependency on libvirt's metadata support to stats collector Line 8: Line 9: There is an issue with libvirt on CentOS 6. The available version does not support part of the metadata API. This generates an error message every 15 seconds. Line 10: Line 11: This patch workarounds this by printing the error only once. printing -> logging Line 12: Line 13: Revert once libvirt supports the xml element metadata on CentOS. Line 14: Line 15: See bug: https://bugzilla.redhat.com/show_bug.cgi?id=1115039 http://gerrit.ovirt.org/#/c/29504/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 312: try: Line 313: metadataCpuLimit = self._vm._dom.metadata( Line 314: libvirt.VIR_DOMAIN_METADATA_ELEMENT, METADATA_VM_TUNE_URI, 0) Line 315: except libvirt.libvirtError as e: Line 316: if (e.get_error_code() != libvirt.VIR_ERR_NO_DOMAIN_METADATA and Is this the most specific error? this can hide various errors under "metadata api not supported" Line 317: VmStatsThread._libvirt_metadata_supported): Line 318: VmStatsThread._libvirt_metadata_supported = False Line 319: self._log.exception("Failed to retrieve QoS metadata") Line 320: -- To view, visit http://gerrit.ovirt.org/29504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d38d3aff3bda42dfaafa87bab9fa5983fb4b9a8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
