Nir Soffer has posted comments on this change. Change subject: vdsm: Shuting down protocol detector fails ......................................................................
Patch Set 1: Another cleaner solution, but require little more code: - Remove the racy self._is_running flag - The acceptor thread will stop only when receiving the byte "1" from the wakeup pipe - We don't have to ignore EPIPE - this can not happen only when stopping twice. -- To view, visit http://gerrit.ovirt.org/29556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82119a61835fe335f2aa5da29fb8d3f2b8ae33fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
