Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Shuting down protocol detector fails ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29556/1/vdsm/protocoldetector.py File vdsm/protocoldetector.py: Line 166: if e.errno == errno.EPIPE: Line 167: pass Line 168: if e.errno == errno.EINTR: Line 169: self.wakeup() Line 170: elif e.errno not in (errno.EAGAIN, errno.EWOULDBLOCK): > EPIPE should be here with EGAIN - these are the errors we can handle. I do not follow. EAGAIN is not possible, right? So why do we swallow it? If it ever happens, it's a bug, and we'd better know about it. Line 171: raise Line 172: Line 173: def _cleanup_wakeup_pipe(self): Line 174: try: -- To view, visit http://gerrit.ovirt.org/29556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82119a61835fe335f2aa5da29fb8d3f2b8ae33fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
