Dan Kenigsberg has posted comments on this change. Change subject: sampling: do not bail out on errors ......................................................................
Patch Set 2: (1 comment) I'm not a great supporter of this kind of protection: it makes developers and user ignore bugs as the one cited in the commit message. I wonder what others think. Can we raise an "alarm" that Engine can poll and show to end users, so that bugs are reported. http://gerrit.ovirt.org/#/c/29401/2/vdsm/virt/sampling.py File vdsm/virt/sampling.py: Line 507 Line 508 Line 509 Line 510 Line 511 This condition seems to refer to an anachronistic https://bugzilla.redhat.com/show_bug.cgi?id=579762 so I am fine with removing it. -- To view, visit http://gerrit.ovirt.org/29401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd05aecc0f66da2bc75f477afc5e17fada0e5f5b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
