Francesco Romani has posted comments on this change. Change subject: sampling: do not bail out on errors ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/29401/2//COMMIT_MSG Commit Message: Line 8: Line 9: The current sampling code for host stats only handles Line 10: TimeoutError gracefully. This is too fragile: the sampling Line 11: code should not give up so easily but instead go ahead Line 12: in face of errors, as the VmStatsThread already do. > Looks like vm stats thread should be fixed to not handle unexpected errors Yep. What an unexpected twist :) Line 13: Line 14: Change-Id: Icd05aecc0f66da2bc75f477afc5e17fada0e5f5b Line 15: Relates-To: https://bugzilla.redhat.com/1113948 http://gerrit.ovirt.org/#/c/29401/2/vdsm/virt/sampling.py File vdsm/virt/sampling.py: Line 505: except vm.TimeoutError: Line 506: self._log.error("Timeout while sampling stats", Line 507: exc_info=True) Line 508: except Exception: Line 509: self._log.exception("Error while sampling stats") > This will spam the logs now if we have a repeating error. Each time you tak Good point. I just thought these errors would be rare, but I don't have any evidence on my side, thus I'll switch to warning(). Line 510: self._stopEvent.wait(self.SAMPLE_INTERVAL_SEC) Line 511: Line 512: @utils.memoized Line 513: def _boot_time(self): -- To view, visit http://gerrit.ovirt.org/29401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd05aecc0f66da2bc75f477afc5e17fada0e5f5b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
