Francesco Romani has posted comments on this change. Change subject: Add API.VM.setIoTune ......................................................................
Patch Set 18: Code-Review-1 (1 comment) The new setIoTune is a quite big chunk of code, but I don't see any obvious way to improve it without some serious and unrelated preparation work. A couple of print statements sneaked into the tests, please remove them (should not be a big deal and no need to reverify the patch after that). -1 Only for visibility. http://gerrit.ovirt.org/#/c/28714/18/tests/vmTests.py File tests/vmTests.py: Line 1204: for drive in drives: Line 1205: machine._devices[drive.type].append(drive) Line 1206: Line 1207: print machine._devices Line 1208: print machine.setIoTune(tunables) Please get rid of these Line 1209: Line 1210: self.assertEqual(expected_io_tune, dom._io_tune) Line 1211: Line 1212: -- To view, visit http://gerrit.ovirt.org/28714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bd48f13311ad2efc4241117a777ca3400c259ea Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
