Martin Sivák has posted comments on this change. Change subject: Add API.VM.setIoTune ......................................................................
Patch Set 22: (2 comments) http://gerrit.ovirt.org/#/c/28714/22/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3778: device_name = io_tune_change.get('name', None) Line 3779: device_path = io_tune_change.get('path', None) Line 3780: io_tune = io_tune_change['ioTune'] Line 3781: Line 3782: # Find the proper device object > please factor out in a separate function. Done Line 3783: for device in self._devices[DISK_DEVICES]: Line 3784: if ((device.name == device_name Line 3785: or ("path" in device and device["path"] == device_path)) Line 3786: and isVdsmImage(device)): Line 3824: dom.removeChild(io_dom_list[0]) Line 3825: io_dom = XMLElement("iotune") Line 3826: ioTuneValuesToDom(io_tune, io_dom) Line 3827: dom.appendChild(io_dom) Line 3828: found_device.specParams['ioTune'] = io_tune > I don't see where the device's _deviceXML field is updated Well dom here is the device's xml object reference or do you mean something else? I am not really sure how the xml/conf interaction should work here so I might have missed something. Line 3829: Line 3830: return {'status': doneCode} Line 3831: Line 3832: def _createTransientDisk(self, diskParams): -- To view, visit http://gerrit.ovirt.org/28714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bd48f13311ad2efc4241117a777ca3400c259ea Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
