Federico Simoncelli has posted comments on this change. Change subject: virt: Restore BC for block type live snapshots ......................................................................
Patch Set 1: Code-Review+1 (1 comment) It seems ok (only +1 because it's a Friday midnight review). http://gerrit.ovirt.org/#/c/29567/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4028: # we specify type='block' and dev=path for block volumes but we Line 4029: # always speficy the file=path for backwards compatibility. Line 4030: args = {'type': sourceType, 'file': newPath} Line 4031: if sourceType == 'block': Line 4032: args['dev'] = newPath > Unrelated to this patch: sourceType looks redundant, it is already specifie What constructor? Anyway we can also use utils.isBlockDevice on newPath (not sure I like to break the encapsulation though, I'd leave it as it is). Line 4033: disk.appendChildWithArgs('source', **args) Line 4034: return disk Line 4035: Line 4036: def _normSnapDriveParams(drive): -- To view, visit http://gerrit.ovirt.org/29567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85290f17842ada6c04695bf45ffd1b1108c63d55 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Elad Ben Aharon <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
