Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Restore BC for block type live snapshots ......................................................................
virt: Restore BC for block type live snapshots Commit 02741ce introduced a regression in older hosts running libvirt < 1.2.2 where libvirt rejects the type='block' and source/dev combination. Eric Blake suggested that this could be worked around by supplying the old format and new format in the domainshapshot XML document. This union would continue to work as before on old hosts but would pick up the correct block snapshot behavior on newer versions. Basically, we still express the disk type but we repeat the newPath inside both a dev and file attribute. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1115126 Change-Id: I85290f17842ada6c04695bf45ffd1b1108c63d55 Signed-off-by: Adam Litke <[email protected]> Reviewed-on: http://gerrit.ovirt.org/29567 Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Federico Simoncelli <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Adam Litke: Verified Federico Simoncelli: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85290f17842ada6c04695bf45ffd1b1108c63d55 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Elad Ben Aharon <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
