Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: migration: simplify the remote port handling ......................................................................
virt: migration: simplify the remote port handling When the destination port for migrations is not explicitely given, the current code in _setupVdsConnection does a clumsy gimmick to get it from the BindingXMLRPC internals. This unnecessarily makes the coupling stricter. Instead, just use the port specified as per configuration, which is the same setting the XMLRPC bindings are using anyway. Change-Id: Iee19377c6387738d7c4d4a898b6e716a1eeb884c Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: http://gerrit.ovirt.org/29048 Reviewed-by: Piotr Kliczewski <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/virt/migration.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/29048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee19377c6387738d7c4d4a898b6e716a1eeb884c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
