Dan Kenigsberg has posted comments on this change. Change subject: virt: migration: simplify the remote port handling ......................................................................
Patch Set 5: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/29048/5//COMMIT_MSG Commit Message: Line 12: Line 13: This unnecessarily makes the coupling stricter. Line 14: Instead, just use the port specified as per configuration, Line 15: which is the same setting the XMLRPC bindings are using Line 16: anyway. While at it, you drop a never-used data member remotePort. Line 17: Line 18: Change-Id: Iee19377c6387738d7c4d4a898b6e716a1eeb884c -- To view, visit http://gerrit.ovirt.org/29048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee19377c6387738d7c4d4a898b6e716a1eeb884c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
