Federico Simoncelli has posted comments on this change. Change subject: Live Merge: improve log messages ......................................................................
Patch Set 3: Code-Review-1 (2 comments) Minor comments. http://gerrit.ovirt.org/#/c/29310/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5690: 'commit') Line 5691: except BlockJobExistsError: Line 5692: self.log.error("Another block job is already active on this disk") Line 5693: return errCode['mergeErr'] Line 5694: self.log.debug("Starting merge with jobUUI Not sure if it's my browser issue but I don't see this call end; missing ") Line 5695: Line 5696: flags = 0 Line 5697: # Indicate that we expect libvirt to maintain the relative paths of Line 5698: # backing files. This is necessary to ensure that a volume chain is Line 5815: newChain = [x for x in device['volumeChain'] Line 5816: if x['volumeID'] in volumes] Line 5817: device['volumeChain'] = drive.volumeChain = newChain Line 5818: Line 5819: def _onBlockJobEvent(self, path, blockJobType, status): Please log something here as well so that we know this was called. Line 5820: if blockJobType != libvirt.VIR_DOMAIN_BLOCK_JOB_TYPE_COMMIT: Line 5821: self.log.warning("Ignoring unrecognized block job type: '%s'", Line 5822: blockJobType) Line 5823: return -- To view, visit http://gerrit.ovirt.org/29310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5d22e4c503d5781eb1dc00c6c326146d5bbbbd1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
