Federico Simoncelli has posted comments on this change. Change subject: Live Merge: improve log messages ......................................................................
Patch Set 4: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/29310/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5592: 'chain': self._driveGetActualVolumeChain(drive)} Line 5593: self.conf['_blockJobs'][jobID] = newJob Line 5594: else: Line 5595: self.log.error("Cannot add block job %s. A block job with id " Line 5596: "%s already exists for image %s", jobID, Minor nit here. Why double space? ("...%s. A block...") Line 5597: job['jobID'], drive['imageID']) Line 5598: raise BlockJobExistsError() Line 5599: self.saveState() Line 5600: -- To view, visit http://gerrit.ovirt.org/29310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5d22e4c503d5781eb1dc00c6c326146d5bbbbd1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
