Michal Skrivanek has posted comments on this change. Change subject: vm: detect migration completed on recovery ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/28511/11/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4080: self.log.debug("Waiting %s seconds for end of migration", timeout) Line 4081: self._incomingMigrationFinished.wait(timeout) Line 4082: Line 4083: try: Line 4084: if not self.recovering: just wondering - is this actually still needed/useful? Line 4085: # Would fail if migration isn't successful, Line 4086: # or restart vdsm if connection to libvirt was lost Line 4087: self._dom = NotifyingVirDomain( Line 4088: self._connection.lookupByUUIDString(self.id), -- To view, visit http://gerrit.ovirt.org/28511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I451c2a940693842e9bf7c63ccc117e75026bb11b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
