Francesco Romani has posted comments on this change. Change subject: vm: detect migration completed on recovery ......................................................................
Patch Set 13: (2 comments) http://gerrit.ovirt.org/#/c/28511/13/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3242: Line 3243: # We should set this event as a last part of drives initialization Line 3244: self._pathsPreparedEvent.set() Line 3245: Line 3246: initDomain = ('migrationDest' not in self.conf) > Why the parenthesis? I don't really see a need and it doesn't help the read Agreed. Will remove. Line 3247: # we need to complete the initialization, including Line 3248: # domDependentInit, after the migration is completed. Line 3249: Line 3250: if not self.recovering and initDomain: Line 3290: for dev in self._customDevices(): Line 3291: hooks.after_device_create(dev._deviceXML, self.conf, Line 3292: dev.custom) Line 3293: Line 3294: if not initDomain: > if initDomain: Agreed, is better Line 3295: return Line 3296: self._domDependentInit() Line 3297: Line 3298: def _updateDevices(self, devices): -- To view, visit http://gerrit.ovirt.org/28511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I451c2a940693842e9bf7c63ccc117e75026bb11b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
