Alon Bar-Lev has posted comments on this change. Change subject: tests: introducing whitebox tests ......................................................................
Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/29745/2//COMMIT_MSG Commit Message: Line 18: because they are aware of the inside implementation (as opposed to Line 19: blackbox tests), but they check that things "really work" (e.g. Line 20: libraries get called, sockets are opened, etc.) , and not just Line 21: the internal logic of some small section of code (which would Line 22: characterize a unit test). it this is the reason, the test can be explicitly enabled by using test framework argument, no? if this is the case, why separate it into own directly? Line 23: Line 24: Change-Id: I4e20d17c3ebee1203bb5a721ce44d5867570ce8e http://gerrit.ovirt.org/#/c/29745/2/tests/Makefile.am File tests/Makefile.am: Line 21: include $(top_srcdir)/build-aux/Makefile.subs Line 22: Line 23: SUBDIRS = \ Line 24: functional \ Line 25: whitebox while you at it, please add $(NULL) at last line Line 26: Line 27: test_modules = \ Line 28: blocksdTests.py \ Line 29: bridgeTests.py \ http://gerrit.ovirt.org/#/c/29745/2/tests/whitebox/Makefile.am File tests/whitebox/Makefile.am: Line 1: # Line 2: # Copyright 2012-2013 Red Hat, Inc. fix Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or Line 17: # Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: Line 21: vdsmwhiteboxtestsdir = ${vdsmtestsdir}/whitebox $() instead of ${} but why are we installing these? if we do not need to install, please use: dist_noinst_PYTHON = Line 22: Line 23: dist_vdsmwhiteboxtests_PYTHON = \ Line 24: alignmentScanTests.py -- To view, visit http://gerrit.ovirt.org/29745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e20d17c3ebee1203bb5a721ce44d5867570ce8e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
