Yoav Kleinberger has posted comments on this change. Change subject: tests: introducing whitebox tests ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/29745/2//COMMIT_MSG Commit Message: Line 18: because they are aware of the inside implementation (as opposed to Line 19: blackbox tests), but they check that things "really work" (e.g. Line 20: libraries get called, sockets are opened, etc.) , and not just Line 21: the internal logic of some small section of code (which would Line 22: characterize a unit test). > it this is the reason, the test can be explicitly enabled by using test fra I assume you meant its own directory. The way I see it, directory structure is meant to convey meaning. So I would actually like to have test/unit, test/whitebox and test/functional You could convey this meaning by documenting in Makefiles, but they are rather unreadable as it is. Line 23: Line 24: Change-Id: I4e20d17c3ebee1203bb5a721ce44d5867570ce8e -- To view, visit http://gerrit.ovirt.org/29745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e20d17c3ebee1203bb5a721ce44d5867570ce8e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
