Ondřej Svoboda has posted comments on this change.

Change subject: api, iproute2, dhclient: Support DHCPv6
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/30554/1/vdsm/network/configurators/iproute2.py
File vdsm/network/configurators/iproute2.py:

Line 252:             if not iface.ipConfig.async and rc:
Line 253:                 raise ConfigNetworkError(ERR_FAILED_IFUP, 'dhclient 
failed')
Line 254:         if iface.ipConfig.dhcpv6:
Line 255:             dhclient = DhcpClient(iface.name, family='6')
Line 256:             rc = dhclient.start(iface.ipConfig.async)
'async' is determined on the basis of 'bootproto', not 'dhcpv6'.
Line 257:             if not iface.ipConfig.async and rc:
Line 258:                 raise ConfigNetworkError(ERR_FAILED_IFUP, 'dhclient6 
failed')
Line 259: 
Line 260:     def ifdown(self, iface):


-- 
To view, visit http://gerrit.ovirt.org/30554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40a3d5d63d14e6a1cb8a70894a63de3a3367b9e7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to