Ondřej Svoboda has posted comments on this change. Change subject: api, iproute2, dhclient: Support DHCPv6 ......................................................................
Patch Set 2: (1 comment) Commented that 'async' has to mirror 'dhcpv6', too. http://gerrit.ovirt.org/#/c/30554/2/vdsm/network/models.py File vdsm/network/models.py: Line 446: 'configurations are mutually exclusive.') Line 447: self.inet4 = inet4 Line 448: self.inet6 = inet6 Line 449: self.bootproto = bootproto Line 450: self.async = (bootproto == 'dhcp' or dhcpv6) and not blocking self.async must be available both for DHCPv4 and DHCPv6 since ifcfg configurator would block VDSM (as is written there) when waiting for a DHCPv6 lease. Line 451: self.ipv6autoconf = ipv6autoconf Line 452: self.dhcpv6 = dhcpv6 Line 453: Line 454: def __repr__(self): -- To view, visit http://gerrit.ovirt.org/30554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40a3d5d63d14e6a1cb8a70894a63de3a3367b9e7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
