Barak Azulay has posted comments on this change. Change subject: api: Add fencingPolicy parameter to fenceNode ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/30762/1/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 294: FencingPolicy The additional parameter is not a policy, It implies a policy but it should contain a list of pairs (SdUUID and HostId). So first the name is incorrect, And second the type is incorrect. Please see patch http://gerrit.ovirt.org/#/c/29157/2/vdsm/rpc/vdsmapi-schema.json,cm , which will not get in about exposing the getHostLeaseStatus as public API. The structure is defined as. ## # @HostIdMap: # # A mapping of hostId indexed by domain UUID. # # Since: 4.15.0 ## {'map': 'HostIdMap', 'key': 'UUID', 'value': 'int'} -- To view, visit http://gerrit.ovirt.org/30762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b1fd9521cebea28d0402e53d46d74b95e73f383 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
