Martin Peřina has posted comments on this change. Change subject: fencing: Skip fencing if host is connected to storage ......................................................................
Patch Set 2: Verified+1 (2 comments) Skipped/initiated fence action is now propagated back to engine and message is displayed to user when host is not fenced because he has live connection to storage http://gerrit.ovirt.org/#/c/30762/2/vdsm/API.py File vdsm/API.py: Line 1133: APIBase.__init__(self) Line 1134: Line 1135: # General Host functions Line 1136: def fenceNode(self, addr, port, agent, username, password, action, Line 1137: secure=False, options='', fencingPolicy=None): > Do we have other types of policy here? No, so name this "policy" Done Line 1138: """Send a fencing command to a remote node. Line 1139: Line 1140: agent is one of (rsa, ilo, drac5, ipmilan, etc) Line 1141: action can be one of (status, on, off, reboot).""" Line 1159: line = 'passwd=XXXX\n' Line 1160: cleantext += line Line 1161: return cleantext Line 1162: Line 1163: def execute_fence_script(fencingPolicy): > This does not execute anything - is is a predicate, and should use name lik Done Line 1164: # skip fence execution if map of storage domains with host id is Line 1165: # entered and at least one storage domain connection from host is Line 1166: # alive Line 1167: execute = True -- To view, visit http://gerrit.ovirt.org/30762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b1fd9521cebea28d0402e53d46d74b95e73f383 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
