Nir Soffer has posted comments on this change. Change subject: Move multipath configuration to vdsm-tool configurator ......................................................................
Patch Set 1: (2 comments) So much nicer when we have several simple patches! Whats missing: 1. checking that multipath is configured when starting vdsm, and failing if multipath is not configured. This should be implemented in the same way we do it for libvirt and sanlock. This addition is a must - we want to move the configuration step to vdsm tool, giving more control to the administrator, but we cannot remove the validation when vdsm is started. 2. Revert http://gerrit.ovirt.org/30704 - When this patch is merged, that patch is not needed any more. 3. Add the bug url from http://gerrit.ovirt.org/30704 to the commit message, since this fix also that bug. The code moved from multipath need some cleanup, but not in this patch. http://gerrit.ovirt.org/#/c/30909/1//COMMIT_MSG Commit Message: Line 8: Line 9: Previously multipath is reconfigured on each vdsm Line 10: service restart. Line 11: Now it will be reconfigured only on user demand. Line 12: We have a bug url for this Line 13: Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da http://gerrit.ovirt.org/#/c/30909/1/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 759: rc, out, err = utils.execCmd(cmd) Line 760: if rc != 0: Line 761: sys.stdout.write("Failed to reload Multipath.") Line 762: Line 763: def isconfigured(self, *args): This should return CONFIGURED, NOT_CONFIGURED, or NOT_SURE, not a boolean. Line 764: """ Line 765: Check the multipath daemon configuration. The configuration file Line 766: /etc/multipath.conf should contain private tag in form Line 767: "RHEV REVISION X.Y" for this check to succeed. -- To view, visit http://gerrit.ovirt.org/30909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
