Nir Soffer has posted comments on this change. Change subject: Move multipath configuration to vdsm-tool configurator ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/30909/2/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 670: Line 671: _MPATH_CONF = "/etc/multipath.conf" Line 672: Line 673: _STRG_MPATH_CONF = ( Line 674: "\n\n" > please..if without those 2 blank lines all stay the same, why do you so car Changing now these lines is a waste of time and make the review harder. We should touch only stuff that matter now. We can improve other stuff later. Line 675: "defaults {\n" Line 676: " polling_interval 5\n" Line 677: " getuid_callout \"%(scsi_id_path)s --whitelisted " Line 678: "--replace-whitespace --device=/dev/%%n\"\n" Line 705: "# RHEV REVISION 0.4", "# RHEV REVISION 0.5", Line 706: "# RHEV REVISION 0.6", "# RHEV REVISION 0.7", Line 707: "# RHEV REVISION 0.8", "# RHEV REVISION 0.9"] Line 708: Line 709: _MPATH_CONF_TAG = "# RHEV REVISION 1.0" > comment? seriously ? please add a comment and explain your investigation of It does not matter now, we don't want to change the logic of the multipath configuration in this patch, just to move it into vdsm-tool. Line 710: _MPATH_CONF_PRIVATE_TAG = "# RHEV PRIVATE" Line 711: Line 712: _MPATH_CONF_TEMPLATE = _MPATH_CONF_TAG + _STRG_MPATH_CONF Line 713: Line 720: def getName(self): Line 721: return 'multipath' Line 722: Line 723: def getServices(self): Line 724: return ["multipathd"] > check the configure code please. we manually stop those services before con I think that stopping multipath while we configuring should be the safest way, and if all other services work like this, then this should be the solution at this point. The nice thing using this logic is simplifying configure(), no need to reload and handle inactive multipathd. Line 725: Line 726: def configure(self): Line 727: """ Line 728: Set up the multipath daemon configuration to the known and -- To view, visit http://gerrit.ovirt.org/30909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
