Dan Kenigsberg has submitted this change and it was merged. Change subject: domainMonitor: Introduce cancellation points ......................................................................
domainMonitor: Introduce cancellation points While monitoring domain, the monitor perform some operations that we would like to avoid if the monitor thread was stopped while running the _monitorDomain method. Example operations are accessing shared storage, which may block for long time, or acquiring a host id. This patch adds the @cancelpoint decorator, that can be used to mark methods as cancellation points. Some of the domain monitor thread methods are marked as cancellation points, ensuring that a monitor will stop as soon as possible when stopped. Change-Id: I0a965758736a0b9fa7ac7c2e105bcbbfb04163b8 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/28721 Reviewed-by: Yoav Kleinberger <[email protected]> Reviewed-by: Federico Simoncelli <[email protected]> --- M lib/vdsm/utils.py M vdsm/storage/domainMonitor.py 2 files changed, 45 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved Yoav Kleinberger: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a965758736a0b9fa7ac7c2e105bcbbfb04163b8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
