Federico Simoncelli has posted comments on this change. Change subject: domainMonitor: Introduce cancellation points ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/28721/4/vdsm/storage/domainMonitor.py File vdsm/storage/domainMonitor.py: Line 207: try: Line 208: self._monitorDomain() Line 209: except utils.Canceled: Line 210: self.log.debug("Canceled domain monitor for %s", self.sdUUID) Line 211: break > ok +1, waiting for this change Line 212: except: Line 213: self.log.error("The domain monitor for %s failed unexpectedly", Line 214: self.sdUUID, exc_info=True) Line 215: self.stopEvent.wait(self.interval) -- To view, visit http://gerrit.ovirt.org/28721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a965758736a0b9fa7ac7c2e105bcbbfb04163b8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
