Dima Kuznetsov has posted comments on this change. Change subject: signals: Handle signals to non-main threads ......................................................................
Patch Set 8: (1 comment) Nir, this time it is just a race in the test :) http://gerrit.ovirt.org/#/c/29392/8/tests/sigutilsTests_child.py File tests/sigutilsTests_child.py: Line 30: def test_signal_times(times): Line 31: times = int(times) Line 32: while counter[signal.SIGUSR1] < times: Line 33: sigutils.wait_for_signal() Line 34: sys.stdout.write('woke up\n') A race was here, at 9th (out of 10) iteration, if signal is received at this point, next iteration won't happen. Line 35: Line 36: Line 37: def test_signal_to_thread(): Line 38: ''' -- To view, visit http://gerrit.ovirt.org/29392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dbcd00cec22ef12f2b6253b016dcbd0aa889583 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
