Yaniv Bronhaim has posted comments on this change. Change subject: refine calculation of cpu topology ......................................................................
Patch Set 9: (3 comments) http://gerrit.ovirt.org/#/c/30896/9/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3407: # @numaTune: #optional Indicates the numatune configuration. Line 3408: # Line 3409: # @guestNumaNodes: #optional Indicates the guest numa topology. Line 3410: # Line 3411: # Since: 4.10.0 change the last version update - 4.16.2 Line 3412: ## Line 3413: {'type': 'VmParameters', Line 3414: 'data': {'acpiEnable': 'bool', '*bootMenuEnable': 'bool', Line 3415: '*cpuShares': 'str', '*custom': 'StringMap', '*devices': ['VmDevice'], Line 3415: '*cpuShares': 'str', '*custom': 'StringMap', '*devices': ['VmDevice'], Line 3416: 'display': 'VmDisplayType', '*hypervEnable': 'bool', Line 3417: 'kvmEnable': 'bool', 'memSize': 'uint', Line 3418: 'nice': 'int', 'smp': 'uint', '*smpCoresPerSocket': 'uint', Line 3419: '*maxNumberOfSockets': 'int', but where do you use this in vdsm? Line 3420: '*smpThreadsPerCore': 'uint', 'timeOffset': 'uint', Line 3421: 'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName': 'str', Line 3422: 'vmType': 'VmType', '*launchPaused': 'bool', Line 3423: 'numaTune': 'NumaTune', 'guestNumaNodes': ['GuestNumaNode']}} http://gerrit.ovirt.org/#/c/30896/9/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 427: cores = int(self.conf.get('smpCoresPerSocket', '1')) Line 428: threads = int(self.conf.get('smpThreadsPerCore', '1')) Line 429: sockets = int(self.conf.get('maxNumberOfSockets', '16')) Line 430: maxVCpus = int(self.conf.get('maxVCpus', str(smp))) Line 431: maxVCpus = min(maxVCpus, (cores * sockets * threads)) a comment for this formula might help me here Line 432: Line 433: return { Line 434: 'smp': smp, Line 435: 'cores': cores, -- To view, visit http://gerrit.ovirt.org/30896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d71dfe98b67440c084b2a7bf8b292f6b9c3ae19 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
