Yaniv Bronhaim has posted comments on this change. Change subject: refine calculation of cpu topology ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/30896/10/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3416: 'display': 'VmDisplayType', '*hypervEnable': 'bool', Line 3417: 'kvmEnable': 'bool', 'memSize': 'uint', Line 3418: 'nice': 'int', 'smp': 'uint', '*smpCoresPerSocket': 'uint', Line 3419: '*maxNumberOfSockets': 'int', Line 3420: '*smpThreadsPerCore': 'uint', 'timeOffset': 'uint', the "Since" change should be here (in VmParameters), no? and the order should be spmCoresPerSocket, SpmThreadsPerCore, maxNumberOfSockets as you did in the comment above. declare the dictionary in the same order (the parser might fail on that.. but im not sure). Line 3421: 'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName': 'str', Line 3422: 'vmType': 'VmType', '*launchPaused': 'bool', Line 3423: 'numaTune': 'NumaTune', 'guestNumaNodes': ['GuestNumaNode']}} Line 3424: -- To view, visit http://gerrit.ovirt.org/30896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d71dfe98b67440c084b2a7bf8b292f6b9c3ae19 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
