Yeela Kaplan has posted comments on this change. Change subject: Move multipath configuration to vdsm-tool configurator ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/30909/3/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 668: Line 669: class MultipathModuleConfigure(_ModuleConfigure): Line 670: Line 671: _MPATH_CONF = "/etc/multipath.conf" Line 672: > add a comment - start with 2 empty lines between the tags and the contents I really disagree with this kind of comment. It feels redundant to me. Line 673: _STRG_MPATH_CONF = ( Line 674: "\n\n" Line 675: "defaults {\n" Line 676: " polling_interval 5\n" Line 704: _OLD_TAGS = ["# RHAT REVISION 0.2", "# RHEV REVISION 0.3", Line 705: "# RHEV REVISION 0.4", "# RHEV REVISION 0.5", Line 706: "# RHEV REVISION 0.6", "# RHEV REVISION 0.7", Line 707: "# RHEV REVISION 0.8", "# RHEV REVISION 0.9"] Line 708: > where is my explanation :( Done Line 709: _MPATH_CONF_TAG = "# RHEV REVISION 1.0" Line 710: # Do not override conf file when private tag added by admin Line 711: _MPATH_CONF_PRIVATE_TAG = "# RHEV PRIVATE" Line 712: Line 706: "# RHEV REVISION 0.6", "# RHEV REVISION 0.7", Line 707: "# RHEV REVISION 0.8", "# RHEV REVISION 0.9"] Line 708: Line 709: _MPATH_CONF_TAG = "# RHEV REVISION 1.0" Line 710: # Do not override conf file when private tag added by admin > this tag\having "# RHEV PRIVATE" means that the configure won't override .. Done Line 711: _MPATH_CONF_PRIVATE_TAG = "# RHEV PRIVATE" Line 712: Line 713: _MPATH_CONF_TEMPLATE = _MPATH_CONF_TAG + _STRG_MPATH_CONF Line 714: -- To view, visit http://gerrit.ovirt.org/30909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
