Federico Simoncelli has posted comments on this change. Change subject: fencing: Skip fencing if host is maintaining its lease ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/30762/5/vdsm/API.py File vdsm/API.py: Line 1184: # seconds. If so, we consider the host Up and we won't execute Line 1185: # fencing, even when it's unreachable from engine Line 1186: for sd, status in result['domains'].iteritems(): Line 1187: if status == storage.clusterlock.HOST_STATUS_LIVE: Line 1188: self.log.debug("Host has live lease to '%s'", sd) live lease *on* Line 1189: return False Line 1190: Line 1191: self.log.debug("Host doesn't have any live lease") Line 1192: return True Line 1236: return {'status': {'code': 0, 'message': message}, Line 1237: 'power': power} Line 1238: threading.Thread(target=fence, args=(script, inp)).start() Line 1239: Line 1240: return { Why different indentation here? (Compared to line 1204) Line 1241: 'status': doneCode, Line 1242: 'operationStatus': 'initiated', Line 1243: } Line 1244: http://gerrit.ovirt.org/#/c/30762/5/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 342: # Line 343: # @options: #optional Additional agent-specific parameters in space-separated Line 344: # <var>=<val> pairs Line 345: # Line 346: # @policy: #optional Additional options needed in fenceNode logic Add the vdsm version of when this is introduced. Line 347: # Line 348: # Returns: Line 349: # Result of specified fence action Line 350: # -- To view, visit http://gerrit.ovirt.org/30762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b1fd9521cebea28d0402e53d46d74b95e73f383 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
