Federico Simoncelli has posted comments on this change. Change subject: fencing: Skip fencing if host is maintaining its lease ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/30762/5/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 310: Line 311: ## Line 312: # @FencingPolicy: Line 313: # Line 314: # Additional options for fenceNode logic. If I understand correctly we have: policy = { 'policyName': policyData, } that in our case is used with: policy = { 'storageDomainHostIdMap': {'domain1': id1, 'domain2': id2, ...} } Do you expect a map of policies to be sent from the engine in the future? (Or can we use another data-structure other than a map?) How would you handle multiple policies? (Should they all be satisfied or would it be enough for 1 to be satisfied?) Please comment here how the API is designed. Line 315: # Line 316: # @storageDomainHostIdMap: #optional map of storage domains and host ids Line 317: # Line 318: # Since: 4.16.0 -- To view, visit http://gerrit.ovirt.org/30762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b1fd9521cebea28d0402e53d46d74b95e73f383 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
