Petr Horáček has posted comments on this change. Change subject: netinfoTests: test fake and hidden dummies, veths ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31166/1/tests/netinfoTests.py File tests/netinfoTests.py: Line 177: dummy.remove(d2) Line 178: veth.remove(v1a) Line 179: veth.remove(v2a) Line 180: Line 181: self.assertTrue(fakes.issubset(nics)) > please add a useful 'msg' to be shown upon failure (with fakes and nics ren Done Line 182: self.assertFalse(hiddens.intersection(nics)) Line 183: Line 184: def testGetBandwidthQos(self): Line 185: notEmptyDoc = minidom.parseString("""<bandwidth> -- To view, visit http://gerrit.ovirt.org/31166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide618510b46eee28d939c32e8188bbd38349d660 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
