Nir Soffer has posted comments on this change. Change subject: vdsm-tool: use geteuid() instead of getuid() for root check. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31317/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-08-11 11:30:33 +0300 Line 4: Commit: Mooli Tayer <[email protected]> Line 5: CommitDate: 2014-08-11 11:30:33 +0300 Line 6: Line 7: vdsm-tool: use geteuid() instead of getuid() for root check. Can you explain why is this more correct, and in which case the former way was broken (sudo I guess)? Line 8: Line 9: Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9 -- To view, visit http://gerrit.ovirt.org/31317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
