mooli tayer has posted comments on this change. Change subject: vdsm-tool: use geteuid() instead of getuid() for root check. ......................................................................
Patch Set 3: I adopted this from comment 5 on http://gerrit.ovirt.org/#/c/31293/2. I explained when this can happen in comment 7 of this patch. The kernal uses effective user ids to check permissions for processes and so should we. that is why "checking for effective user id is more accurate for permissions check." -- To view, visit http://gerrit.ovirt.org/31317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
