Federico Simoncelli has posted comments on this change. Change subject: sparsify: integrating virt-sparsify into vdsm ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/28328/10/vdsm/storage/image.py File vdsm/storage/image.py: Line 539: dstVolClass = sdCache.produce(dstSdUUID).getVolumeClass() Line 540: Line 541: # Get source, destination and temporary volumes Line 542: # sdCache.produce.produceVolume gives volumes that return getVolumePath Line 543: # with a colon (:) for NFS servers. So, we're using volClass(). Minor, please add the bz reference: RHBZ#1128942 Line 544: srcVolume = srcVolClass(self.repoPath, srcSdUUID, srcImgUUID, Line 545: srcVolUUID) Line 546: dstVolume = dstVolClass(self.repoPath, dstSdUUID, dstImgUUID, Line 547: dstVolUUID) -- To view, visit http://gerrit.ovirt.org/28328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7bd2b4b6d45781fa27a128dd68d14b7561d0901 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Utkarsh Singh <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Utkarsh Singh <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
