Michal Skrivanek has posted comments on this change. Change subject: sparsify: integrating virt-sparsify into vdsm ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/28328/11/vdsm.spec.in File vdsm.spec.in: Line 142: Line 143: %if 0%{?rhel} Line 144: Requires: libguestfs-tools-c >= 1:1.20.11-10 Line 145: %else # fedora Line 146: Requires: libguestfs-tools-c >= 1:1.26.7-2 > Until F19 is officially not supported, we should support it or disable the I'm not 100% sure but I think we only support active Fedora releases, i.e. F19 would be EOL long before 3.6 too. Again, we're at the beginning of 3.6 cycle, there's not going to be any beta builds for a long time. I think we can safely say 3.6 is F20+, and EL6.6+ it may be a bit more friendly for right now to use >=20 for these specific versions, but I wouldn't bother with any further logic about enabled/disabled. Line 147: %endif Line 148: Line 149: %if 0%{?rhel} >= 7 || 0%{?fedora} >= 18 Line 150: Requires: libvirt-daemon >= 1.0.2-1 -- To view, visit http://gerrit.ovirt.org/28328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7bd2b4b6d45781fa27a128dd68d14b7561d0901 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Utkarsh Singh <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Utkarsh Singh <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
